Skip to content

Add out keyword to dpt.take #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2025
Merged

Add out keyword to dpt.take #2010

merged 7 commits into from
Mar 17, 2025

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 21, 2025

This PR proposes the addition of the out keyword in dpt.take, supported by most other libraries (NumPy, Torch, etc.)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Feb 21, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_536 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2025

Coverage Status

coverage: 87.677% (+0.03%) from 87.652%
when pulling 6f7a653 on support-out-kwarg-take
into e7b2b1b on master.

@ndgrigorian ndgrigorian force-pushed the support-out-kwarg-take branch from 1f0dae8 to 111fd09 Compare March 13, 2025 22:04
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_47 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian marked this pull request as ready for review March 13, 2025 23:16
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_49 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian requested a review from vtavana March 14, 2025 20:28
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_52 ran successfully.
Passed: 895
Failed: 2
Skipped: 126

@ndgrigorian ndgrigorian force-pushed the support-out-kwarg-take branch from 525962a to 6f7a653 Compare March 17, 2025 18:21
@ndgrigorian ndgrigorian requested a review from vtavana March 17, 2025 18:21
@vtavana vtavana assigned vtavana and unassigned vtavana Mar 17, 2025
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ndgrigorian!

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_57 ran successfully.
Passed: 894
Failed: 3
Skipped: 126

@ndgrigorian ndgrigorian merged commit 45ab64c into master Mar 17, 2025
68 of 70 checks passed
@ndgrigorian ndgrigorian deleted the support-out-kwarg-take branch March 17, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants